proxy protocol: new feature auto-detect proxy protocol #18951

kdorosh · 2021-11-09T22:08:55Z

Signed-off-by: Kevin Dorosh kevin.dorosh@solo.io

Commit Message: Auto-detect proxy protocol
Additional Description: Allows users to opt-in to functionality to auto-detect proxy protocol if present, and skip the filter if it's not present.
Risk Level: Low, opt-in new feature only hits new codepath if configured
Testing: Added tests for new codepath that cover both passthrough and fragmented proxy protocol scenarios
Docs Changes: N/A, outside of auto-generated API docs
Fixes: #18888

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

repokitteh-read-only · 2021-11-09T22:08:59Z

Hi @kdorosh, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #18951 was opened by kdorosh.

see: more, trace.

repokitteh-read-only · 2021-11-09T22:09:05Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #18951 was opened by kdorosh.

see: more, trace.

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

…-fork into auto_detect_proxy_protocol Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

soulxu · 2021-11-10T09:14:21Z

source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc

@@ -434,6 +443,9 @@ ReadOrParseState Filter::readProxyHeader(Network::IoHandle& io_handle) {
    if (nread < 1) {
      ENVOY_LOG(debug, "failed to read proxy protocol (no bytes read)");
      return ReadOrParseState::Error;
+    } else if (nread < PROXY_PROTO_V2_HEADER_LEN && config_.get()->detectProxyProtocol()) {


if the client send a partial v1 protocol header, I feel this will skip the process the v1 protocol header. it would be great to add an unitest for this case.

thanks for the feedback, addressed in ed4fb54

related #18951 (comment)

soulxu · 2021-11-10T09:17:10Z

api/envoy/extensions/filters/listener/proxy_protocol/v3/proxy_protocol.proto

+  // NOTICE: only enable if ALL traffic to the listener comes from a trusted source.
+  // Defaults to false. If true, attempt to detect proxy protocol if present, and allow
+  // requests through if proxy protocol is not used on the connection.
+  bool detect_proxy_protocol = 2;


I feel the major goal is allow the requests through if proxy protocol is not used. And actually the whole proxy protocol filter is about detect the proxy protocol, so this option name feels confuse. Should we call it something like allow_requests_with_proxy_protocol?

+1 please clarify the name.

I like that better as well, addressed in bcc7aef

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

kdorosh · 2021-11-10T15:04:16Z

thanks for the feedback @soulxu, please let me know if there's anything else you need on my end. also happy to chat on slack if that's easier, I'm in the envoy slack as @kdorosh

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

adisuissa

Thanks for working on this.
Left a few comments.

adisuissa · 2021-11-10T15:02:08Z

api/envoy/extensions/filters/listener/proxy_protocol/v3/proxy_protocol.proto

@@ -40,4 +40,9 @@ message ProxyProtocol {

  // The list of rules to apply to requests.
  repeated Rule rules = 1;
+
+  // NOTICE: only enable if ALL traffic to the listener comes from a trusted source.


Should probably in an .. attention:: clause.
See example.

I also suggest to rephrase the comment, starting with with it does, its default value, and then the notice part.

Thanks for the example, addressed in 91c9a1b

adisuissa · 2021-11-10T15:02:31Z

api/envoy/extensions/filters/listener/proxy_protocol/v3/proxy_protocol.proto

+  // NOTICE: only enable if ALL traffic to the listener comes from a trusted source.
+  // Defaults to false. If true, attempt to detect proxy protocol if present, and allow
+  // requests through if proxy protocol is not used on the connection.
+  bool detect_proxy_protocol = 2;


+1 please clarify the name.

adisuissa · 2021-11-10T15:04:41Z

source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc

@@ -47,6 +47,7 @@ Config::Config(
    Stats::Scope& scope,
    const envoy::extensions::filters::listener::proxy_protocol::v3::ProxyProtocol& proto_config)
    : stats_{ALL_PROXY_PROTOCOL_STATS(POOL_COUNTER(scope))} {
+  detect_proxy_protocol_ = proto_config.detect_proxy_protocol();


Should be set in the c'tor's member initialization list above.

Addressed in c45ecc7

adisuissa · 2021-11-10T15:07:15Z

source/extensions/filters/listener/proxy_protocol/proxy_protocol.h

+   * Filter configuration that determines if we should pass-through failed proxy protocol
+   * requests. Should only be configured to true for trusted downstreams.
+   */
+  bool detectProxyProtocol() const;


The name here should also be clear (following the api field name change).

adisuissa · 2021-11-10T15:08:52Z

test/extensions/filters/listener/proxy_protocol/proxy_protocol_test.cc

@@ -222,6 +222,19 @@ TEST_P(ProxyProtocolTest, V1Basic) {
  disconnect();
 }

+TEST_P(ProxyProtocolTest, DetectNoProxyProtocol) {


Please add a comment on what the test is validating.

Addressed in 4259f1a, please let me know if this doesn't clarify what might have been confusing

adisuissa · 2021-11-10T15:11:14Z

source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc

+  // Release the file event so that we do not interfere with the connection read events.
+  io_handle.resetFileEvents();
+  cb_->continueFilterChain(true);
+  return ReadOrParseState::Done;


This method doesn't need to return anything, and the returned status should probably be only at the end of Filter::onReadWorker()

agree, addressed in 2b4a89a

adisuissa · 2021-11-10T15:12:53Z

Just realized there was a race where some of the comments were addressed in a recent commit.
Please ping me once the other comments are addressed.

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

kdorosh · 2021-11-10T16:17:59Z

@adisuissa all comments should be addressed

soulxu · 2021-11-10T16:07:38Z

test/extensions/filters/listener/proxy_protocol/proxy_protocol_test.cc

+  proto_config.set_allow_requests_without_proxy_protocol(true);
+  connect(true, &proto_config);
+
+  write("PROXY TCP4");


We should test the case of the first write is not full v1 protocol signature, like just one char 'P'

Addressed in 6a0d49b

I'm actually not sure this is possible simultaneously with the fragmented/partial protocol without the possibility for false positive, e.g.

TEST_P(ProxyProtocolTest, TinyPartialV1ReadWithAllowNoProxyProtocolThisFails) { envoy::extensions::filters::listener::proxy_protocol::v3::ProxyProtocol proto_config; proto_config.set_allow_requests_without_proxy_protocol(true); connect(true, &proto_config); write("P"); // matches the beginning of v1 proxy protocol dispatcher_->run(Event::Dispatcher::RunType::NonBlock); write("BOGUS"); expectData("PBOGUS"); // we will consume `P` and upstream gets `BOGUS` not `PBOGUS` disconnect(); }

this is why in the initial implementation I required that the initial read from recv have enough bytes available on the initial MSG_PEEK to make the determination on the v1/v2 proxy header.

We can leave the PR as it is (or perhaps preferably throw a hard error if we consumed some bytes and then realize we had a false positive?) with the understanding that there could be false positives on identifying proxy protocol, additionally with the understanding that this is quite rare and will not likely happen in practice (except perhaps for single byte reads of P and HTTP POST/PUT request?). In exchange, we get support for fragmented/partial reads. Thoughts?

Also willing to go back to my original version (before 6a0d49b which addresses the initial concern with partial reads) which addresses the potential false positive here

I'm not following. How would the filter consume the P only?

Running the test above, we do recv with MSG_PEEK and just get P here.

Then before we continue the loop, we read that byte for real (no MSG_PEEK) here. Thus when we do our second recv and we get BOGUS we have already consumed P. We correctly identify that the request is not proxy protocol, but the request forwarded upstream has a missing byte(s) (in this case, just P).

The only way I see to avoid false positives identifying the header and always send the correct response up the filter chain is to require that the initial MSG_PEEK has enough bytes to detect v1/v2 header (at most 16, which seems reasonable for this opt-in only codepath)

Oh, I see.

I think you need to fix this case. You may have to restructure the code such that no bytes are read (without MSG_PEEK) until we've decided 100% whether this is a proxy header or not.

I think it's probably good enough to look for either PROXY_PROTO_V1_SIGNATURE or PROXY_PROTO_V2_SIGNATURE. If the connections starts with either of those, but then doesn't have a valid full proxy protocol header, abort the connection as we currently do. If the connection starts with bytes that match neither of those signatures, and the new option is enabled, don't read() any bytes and continue the filter chain. Will that work?

I think it will work. Implemented in 6f19883 and 0927000

soulxu · 2021-11-10T16:18:19Z

source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc

@@ -434,6 +445,13 @@ ReadOrParseState Filter::readProxyHeader(Network::IoHandle& io_handle) {
    if (nread < 1) {
      ENVOY_LOG(debug, "failed to read proxy protocol (no bytes read)");
      return ReadOrParseState::Error;
+    } else if (nread < PROXY_PROTO_V2_HEADER_LEN &&
+               config_.get()->allowRequestsWithoutProxyProtocol()) {
+      if (nread < PROXY_PROTO_V1_SIGNATURE_LEN ||


Although it is rare case, there still have the chance of receiving the partial v1 signature, like just a 'P' char, the left of the signature received by the second recv call. But this check will just skip the left of signature checking.

we could return SkipFilterError at https://github.com/envoyproxy/envoy/pull/18951/files#diff-a35fc10b1ce97239d02ac1791aac05069eaf253d8efc77cefe93749f901e36abL446
Then it will got all the data, and compared the signature of v1 and v2.

But if we only receive very short data from the client (short than both v1 and v2 signature), then I feel we only can waiting for a timeout of listener filter. But that is bad for the usecase of issue.

Another idea is if the nread is less than v1 and v2 signature, then we compare part of signature, like if the first byte is X', then compare to the first byte of v1 signature, it is P`. Also compare the first byte of v2 signature, then we know it can't be the proxy protocol.

@soulxu can you update the link from

we could return SkipFilterError at https://github.com/envoyproxy/envoy/pull/18951/files#diff-a35fc10b1ce97239d02ac1791aac05069eaf253d8efc77cefe93749f901e36abL446
Then it will got all the data, and compared the signature of v1 and v2.

to a link to main / a commit and where you're proposing this change? I think with the recent commits to this PR that the link provided is dated, I'm not sure where you're proposing we return the error

also related #18951 (comment)

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

ggreenway · 2022-05-02T21:30:07Z

I like the current version better, due to simplicity. In nearly all cases, all the bytes for comparision will arrive in the first packet, and we're only comparing roughly two machine words of data (on 64-bit); I think the performance difference will be unmeasurable. I think the simplicity out-weights the small amount of duplication (of cpu cycles and code) in this case.

soulxu · 2022-05-02T22:35:15Z

I think

Agree with this version is more simple.

@kdorosh thanks for your patience and trying out two versions, currently code is LGTM now

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

ggreenway

Ugh; I wrote all this yesterday and forgot to hit "submit review". Sorry for the delay.

/wait

ggreenway · 2022-05-03T15:34:20Z

api/envoy/extensions/filters/listener/proxy_protocol/v3/proxy_protocol.proto

+  //   For more information on the security implications of this feature, see
+  //   https://www.haproxy.org/download/2.1/doc/proxy-protocol.txt
+  //
+  //   While incredibly rare, requests of 12 or fewer bytes that match the


I think you can remove "While incredibly rare" from the docs.

Also, I think this paragraph should either have attention:: or note:: header above it.

addressed in 392124e

ggreenway · 2022-05-03T15:34:51Z

docs/root/version_history/current.rst

@@ -45,6 +45,7 @@ New Features
 * dns_resolver: added :ref:`include_unroutable_families<envoy_v3_api_field_extensions.network.dns_resolver.apple.v3.AppleDnsResolverConfig.include_unroutable_families>` to the Apple DNS resolver.
 * ext_proc: added support for per-route :ref:`grpc_service <envoy_v3_api_field_extensions.filters.http.ext_proc.v3.ExtProcOverrides.grpc_service>`.
 * on_demand: :ref:`OnDemand <envoy_v3_api_msg_extensions.filters.http.on_demand.v3.OnDemand>` got extended to hold configuration for on-demand cluster discovery. A similar message for :ref:`per-route configuration <envoy_v3_api_msg_extensions.filters.http.on_demand.v3.PerRouteConfig>` is also added.
+* proxy protocol: added support for allowing requests without proxy protocol on the listener from trusted downstreams as an opt-in flag.


Please add a link to the new config setting.

addressed in 392124e

ggreenway · 2022-05-03T15:37:14Z

source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc

@@ -78,6 +83,8 @@ Network::FilterStatus Filter::onData(Network::ListenerFilterBuffer& buffer) {
    return Network::FilterStatus::StopIteration;
  } else if (read_state == ReadOrParseState::TryAgainLater) {
    return Network::FilterStatus::StopIteration;
+  } else if (read_state == ReadOrParseState::SkipFilter) {


Can you make this into a switch/case on read_state? Then the compiler can warn if not all cases are handled.

addressed in 392124e

ggreenway · 2022-05-03T15:38:45Z

source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc

+    if (!matchv2 && !matchv1) {
+      // The bytes we have seen so far do not match v1 or v2 proxy protocol, so we can safely
+      // short-circuit
+      ENVOY_LOG(debug, "request does not use v1 or v2 proxy protocol, forwarding as is");


This should be at trace level because it is expected to happen in this configuration

addressed in 392124e

ggreenway · 2022-05-03T15:39:45Z

source/extensions/filters/listener/proxy_protocol/proxy_protocol.h

 private:
  absl::flat_hash_map<uint8_t, KeyValuePair> tlv_types_;
+  const bool allow_requests_without_proxy_protocol_{};


This doesn't need the {} initializer at the end because it is always initialized in the constructor.

addressed in 392124e

ggreenway · 2022-05-03T15:42:06Z

test/extensions/filters/listener/proxy_protocol/proxy_protocol_test.cc

+  std::string msg = "data";
+  EXPECT_GT(PROXY_PROTO_V1_SIGNATURE_LEN,
+            msg.length()); // Ensure we attempt parsing byte by byte using `search_index_`
+  EXPECT_GT(PROXY_PROTO_V2_SIGNATURE_LEN, msg.length());


addressed in 392124e

ggreenway · 2022-05-03T15:42:23Z

test/extensions/filters/listener/proxy_protocol/proxy_protocol_test.cc

+  EXPECT_GT(PROXY_PROTO_V2_SIGNATURE_LEN, msg.length());
+
+  write(msg);
+


delete extra newline

addressed in 392124e

ggreenway · 2022-05-03T15:42:28Z

test/extensions/filters/listener/proxy_protocol/proxy_protocol_test.cc

+  write(msg);
+
+  expectData(msg);
+


delete extra newline

addressed in 392124e

ggreenway · 2022-05-03T15:43:41Z

test/extensions/filters/listener/proxy_protocol/proxy_protocol_test.cc

+  connect(true, &proto_config);
+
+  std::string msg = "more data more data more data";
+  EXPECT_GT(msg.length(),


addressed in 392124e

ggreenway · 2022-05-03T15:52:02Z

test/extensions/filters/listener/proxy_protocol/proxy_protocol_test.cc

@@ -526,6 +608,19 @@ TEST_P(ProxyProtocolTest, V2ShortV4) {
  expectProxyProtoError();
 }

+TEST_P(ProxyProtocolTest, V2ShortV4WithAllowNoProxyProtocol) {
+  // An ipv4/tcp connection that has incorrect addr-len encoded


An ipv4/tcp PROXY header that....

addressed in 392124e

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

kdorosh · 2022-05-04T16:10:07Z

Ugh; I wrote all this yesterday and forgot to hit "submit review". Sorry for the delay.

@ggreenway no problem at all, thanks again for the feedback and detailed review!

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

soulxu

LGTM, thanks

ggreenway

Just one final nit.

@adisuissa can you review the API?

ggreenway · 2022-05-05T15:30:50Z

source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc

-  } else if (read_state == ReadOrParseState::SkipFilter) {
+  case ReadOrParseState::SkipFilter:
+    return Network::FilterStatus::Continue;
+  default:


Please remove the default case. Then the compiler will warn/error if there are missing enum cases. I think it's possible that you won't need the return outside the switch either, if all cases are handled and all of them have a return.

addressed in 5c50e23

unfortunately the compiler isn't smart enough to tell that every case is implemented and returns; thus we need the ghost "default" case at the end of the function after the switch statement

source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc: In member function 'virtual Envoy::Network::FilterStatus Envoy::Extensions::ListenerFilters::ProxyProtocol::Filter::onData(Envoy::Network::ListenerFilterBuffer&)': source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc:93:1: error: control reaches end of non-void function [-Werror=return-type] 93 | } | ^

I removed the default case regardless and confirmed that compiler will fail if any case is not implemented

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

ggreenway · 2022-05-05T20:16:35Z

/retest

repokitteh-read-only · 2022-05-05T20:16:39Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18951 (comment) was created by @ggreenway.

see: more, trace.

adisuissa

/lgtm api

kdorosh · 2022-05-06T04:29:00Z

@adisuissa ci is passing; I think we need a final approval from you here since you requested changes before? Thanks!

…voyproxy#18951) Allows users to opt-in to functionality to auto-detect proxy protocol if present, and skip the filter if it's not present. Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Auto-detect proxy protocol

278ce7e

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

repokitteh-read-only bot added the api label Nov 9, 2021

repokitteh-read-only bot assigned adisuissa Nov 9, 2021

Kevin Dorosh added 3 commits November 10, 2021 03:07

Fix format

121e87d

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Merge branch 'auto_detect_proxy_protocol' of github.com:solo-io/envoy…

2d43ae3

…-fork into auto_detect_proxy_protocol Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Fix format

de6b7f2

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

kdorosh changed the title ~~Auto-detect proxy protocol~~ proxy protocol: auto-detect proxy protocol Nov 10, 2021

kdorosh changed the title ~~proxy protocol: auto-detect proxy protocol~~ proxy protocol: new feature auto-detect proxy protocol Nov 10, 2021

Kevin Dorosh added 3 commits November 10, 2021 03:15

Merge branch 'main' into auto_detect_proxy_protocol

3a36695

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Fix merge

409f94c

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Clearer error message

ae19e1f

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

soulxu suggested changes Nov 10, 2021

View reviewed changes

Kevin Dorosh added 3 commits November 10, 2021 14:46

Add unit test for partial v1 protocol

ed4fb54

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Rename new field to

bcc7aef

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Fix format

8c87bcd

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Minor tweak to version history note

4aa520e

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

adisuissa requested changes Nov 10, 2021

View reviewed changes

Kevin Dorosh added 3 commits November 10, 2021 15:20

Use attention clause in API comment

91c9a1b

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Set in ctor initialization list

c45ecc7

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Add comment to clarify test

4259f1a

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

yanavlasov assigned ggreenway Nov 10, 2021

Kevin Dorosh added 2 commits November 10, 2021 15:28

Return value was only used in one of two return paths, tiny refactor

2b4a89a

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Fix format

f105c3d

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

soulxu reviewed Nov 10, 2021

View reviewed changes

Test case with partial signature, just char

6a0d49b

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Merge branch 'main' into auto_detect_proxy_protocol

f3d65e9

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Merge branch 'main' into auto_detect_proxy_protocol

b2d467e

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

kdorosh requested a review from ggreenway May 3, 2022 16:02

Kevin Dorosh added 3 commits May 3, 2022 19:17

Merge branch 'main' into auto_detect_proxy_protocol

45e9c24

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Add changelog

056f74f

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Remove current.rst file that was added in bad merge

39e7b50

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

ggreenway requested changes May 4, 2022

View reviewed changes

repokitteh-read-only bot added the waiting label May 4, 2022

PR comments

392124e

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

repokitteh-read-only bot removed the waiting label May 4, 2022

Merge branch 'main' into auto_detect_proxy_protocol

307df1c

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

soulxu previously approved these changes May 4, 2022

View reviewed changes

ggreenway requested changes May 5, 2022

View reviewed changes

Kevin Dorosh added 2 commits May 5, 2022 15:41

Ensure every case is handled in switch statement

5c50e23

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

Merge branch 'main' into auto_detect_proxy_protocol

36bbfa2

Signed-off-by: Kevin Dorosh <kevin.dorosh@solo.io>

kdorosh dismissed soulxu’s stale review via 36bbfa2 May 5, 2022 15:41

ggreenway approved these changes May 5, 2022

View reviewed changes

adisuissa reviewed May 5, 2022

View reviewed changes

repokitteh-read-only bot removed the api label May 5, 2022

ggreenway enabled auto-merge (squash) May 5, 2022 20:22

adisuissa approved these changes May 6, 2022

View reviewed changes

ggreenway merged commit 18c59ea into envoyproxy:main May 6, 2022

kdorosh mentioned this pull request May 6, 2022

move to upstream proxy protocol filter for enterprise kgateway-dev/kgateway#6420

Closed

		EXPECT_GT(PROXY_PROTO_V2_SIGNATURE_LEN, msg.length());

		write(msg);

proxy protocol: new feature auto-detect proxy protocol #18951

proxy protocol: new feature auto-detect proxy protocol #18951

Conversation

kdorosh commented Nov 9, 2021 • edited Loading

repokitteh-read-only bot commented Nov 9, 2021

repokitteh-read-only bot commented Nov 9, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kdorosh commented Nov 10, 2021

adisuissa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adisuissa commented Nov 10, 2021

kdorosh commented Nov 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kdorosh Nov 10, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kdorosh Nov 10, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ggreenway commented May 2, 2022

soulxu commented May 2, 2022

ggreenway left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kdorosh commented May 4, 2022

soulxu left a comment

Choose a reason for hiding this comment

ggreenway left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kdorosh May 5, 2022 • edited Loading

Choose a reason for hiding this comment

ggreenway commented May 5, 2022

repokitteh-read-only bot commented May 5, 2022

adisuissa left a comment

Choose a reason for hiding this comment

kdorosh commented May 6, 2022

kdorosh commented Nov 9, 2021 •

edited

Loading

kdorosh Nov 10, 2021 •

edited

Loading

kdorosh Nov 10, 2021 •

edited

Loading

kdorosh May 5, 2022 •

edited

Loading